-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-export initialize_contract
function
#1077
Conversation
I want to keep |
Codecov Report
@@ Coverage Diff @@
## master #1077 +/- ##
==========================================
- Coverage 78.70% 75.22% -3.48%
==========================================
Files 253 253
Lines 9411 9409 -2
==========================================
- Hits 7407 7078 -329
- Misses 2004 2331 +327
Continue to review full report at Codecov.
|
It's unclear if we're gonna keep |
7cde1ac
to
17fd88d
Compare
🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑These are the results when building the
Link to the run | Last update: Tue Feb 15 20:04:37 CET 2022 |
Resurrected because use-ink/cargo-contract#431 is moving forward, which looks for instances of |
Sorry, I already mention that, but I didn't get any comment=) What do you think about that idea? It allows us to simplify the definition of the constructor for the user and it also is more intuitive for Solidity developers. |
I don't think users should be accessing stuff from the
codegen
module directly, so thisPR re-exports
initialize_contract
so it can be used from theink_lang
module instead.