Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InkProject not exported from ink_metadata #1521

Closed
0xLucca opened this issue Mar 4, 2024 · 0 comments · Fixed by #1522
Closed

InkProject not exported from ink_metadata #1521

0xLucca opened this issue Mar 4, 2024 · 0 comments · Fixed by #1522

Comments

@0xLucca
Copy link
Contributor

0xLucca commented Mar 4, 2024

/~https://github.com/paritytech/cargo-contract/blob/bcc1c8cc5a748b3f421f40b9d9a9d7d355c8acb2/crates/transcode/src/lib.rs#L177

In the transcode crate, the InkProject type is currently unexported, making it inaccessible to users. It would be beneficial to expose the ink_metadata module entirely, allowing users to include it in their projects without the need to explicitly add the ink_metadata crate solely for accessing certain types.

We propose updating the lib.rs file as follows:

// Other imports
pub use ink_metadata;
...

This change would enable users to access the necessary types conveniently.

0xLucca added a commit to inkscopexyz/cargo-contract that referenced this issue Mar 4, 2024
cmichi added a commit that referenced this issue Mar 7, 2024
* Solve issue #1521

* - Export ink_metadata types

* Reexport whole crate

* Update CHANGELOG.md

Co-authored-by: Michael Müller <mich@elmueller.net>

---------

Co-authored-by: Michael Müller <mich@elmueller.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant