Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

offboresight (RS2-RCM) ; denoising optional (RCM) ; recalibration (S1) #217

Merged
merged 5 commits into from
Aug 8, 2024
Merged

offboresight (RS2-RCM) ; denoising optional (RCM) ; recalibration (S1) #217

merged 5 commits into from
Aug 8, 2024

Conversation

vincelhx
Copy link
Collaborator

@vincelhx vincelhx commented Aug 5, 2024

  • adding offboresight angle (RS2-RCM)
  • new rule for recalibration

@agrouaze agrouaze added the enhancement New feature or request label Aug 5, 2024
@vincelhx vincelhx requested a review from agrouaze August 6, 2024 09:10
agrouaze
agrouaze approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@agrouaze agrouaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, just a comment, it is not minor change regarding RCM part ;-)

@vincelhx vincelhx changed the title minor changes offboresight (RS2-RCM) ; denoising optional (RCM) ; recalibration (S1) Aug 6, 2024
@vincelhx
Copy link
Collaborator Author

vincelhx commented Aug 6, 2024

true. For this part, i couldnt test on a file that was already denoised : no file found on disk yet

@vincelhx vincelhx marked this pull request as draft August 6, 2024 14:39
@vincelhx vincelhx marked this pull request as ready for review August 7, 2024 20:15
@agrouaze agrouaze merged commit 1ffc7bf into umr-lops:develop Aug 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrouaze agrouaze agrouaze approved these changes

Assignees

@vincelhx vincelhx

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincelhx @agrouaze