Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add radarsat2 in xsar #136

Merged
merged 53 commits into from
Apr 4, 2023
Merged

Add radarsat2 in xsar #136

merged 53 commits into from
Apr 4, 2023

Conversation

agrouaze
Copy link
Member

@agrouaze agrouaze commented Feb 1, 2023

No description provided.

@agrouaze agrouaze requested a review from yreynaud February 1, 2023 09:33
@agrouaze agrouaze added the enhancement New feature or request label Feb 1, 2023
@agrouaze agrouaze marked this pull request as draft February 1, 2023 09:35
yreynaud added 20 commits February 1, 2023 11:35
@yreynaud
Add ne*z lut and lut denoised to _dataset
0a4c226
@yreynaud
Add flip for lines and samples to respect the xsar convention
7861a06
@yreynaud
Merge radarSat2 datatree with the initial reader datatree
4b87f66
@yreynaud
Add the possibility to use open_dataset and open_datatree functions f…
8c9fa2d 
…rom xsar (whatever S1 or RS2)
@yreynaud
Choose initial resampling method (with rectBivariateSpline) + Add map…
57eb68d 
…_block_coords notion + denoising okay
@yreynaud
Add atributes to the dataset
234023e
@yreynaud
Change methods from meta to get land_mask by abstract ones, located i…
a3e7605 
…n utils.py. Add stop date and start date to attributes. Add ground heading
@yreynaud
Add missing function for land_mask and ground heading. Correct transp…
d01dc8b 
…ose bug for times. Put lines flipped and samples flipped in variables instead of attributes
@yreynaud
Add velocity
72eb4a0
@yreynaud
reformat datatree
c8711f4
@yreynaud
Add comments and improve docstring for the function that reformat the…
e78d92b 
… datatree of radarSat2Dataset
@yreynaud
Add abstract layer for Dataset and Meta by adding BaseDataset and Bas…
b280695 
…eMeta classes
@yreynaud
Remove unnecessary imports + remove mask.py (old version)
79db9b6
@yreynaud
Push abstraction further, making code cleaner
dca20e2
@yreynaud
Add lazy_loading for luts (calibration + noise)
b089601
@yreynaud
Correct bug with dataset setter and getter
d9d6325
@yreynaud
Remove dataset deleter from BaseDataset
9e79e0c
@yreynaud
give a __repr__ to RadarSat2Dataset and add missing dataset deleter t…
52ee304 
…o Sentinel1Dataset
@yreynaud
Correct bug with dataset names
e932e6b
@yreynaud
Remove parenthesis from mask_names in land_mask_slc_per_bursts
fbdeadf
@agrouaze
Copy link
Member Author

agrouaze commented Mar 3, 2023

with /~https://github.com/umr-lops/xradarsat2/releases/tag/0.0.1 it should solve the issue with upper/lower case in xradarsat2 dependency and manage to go through the build.

@agrouaze agrouaze self-assigned this Mar 27, 2023
@agrouaze agrouaze marked this pull request as ready for review March 27, 2023 08:09
@agrouaze
Copy link
Member Author

@yreynaud can you merge with develop ?

yreynaud and others added 14 commits March 28, 2023 09:44
@yreynaud
Merge branch 'develop' into yann
0b94080
@yreynaud
remove _get_lut from sentinel_dataset (already in base_dataset)
f43e462
@yreynaud
pass name to lowercase in config files
8a87d35
@yreynaud
remove xradarsat2 from environment.yml
7d580ca
@yreynaud
push notebook examples with the good kernel
6b78caf
@yreynaud
add xradarsat2 as dependency for the doc
a106a73
@yreynaud
Add documentation for radarsat2.ipynb and uml diagrams
ccc1300
@yreynaud
adapt docstring and add BaseDataset and BaseMeta documentation
5d9aa3b
@yreynaud
Review notebook documentation examples, and regroupe differents class…
cfdd8aa 
…es in the API reference documentation
@yreynaud
Remove some hidden functions (because directly used in radarsat2)
f229dee
@yreynaud
update uml diagrams
7fa2f6e
@yreynaud
Add/update links to the API in the documentation notebooks
0a106c7
@yreynaud
Flip lines and samples in the metadata (instead pf after the treatmen…
b5f6961 
…t) to correct a bug with ground_heading
@yreynaud
Update uml with the new version
c42210c
@agrouaze agrouaze merged commit 048f17e into umr-lops:develop Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yreynaud yreynaud Awaiting requested review from yreynaud

Assignees

@agrouaze agrouaze

@yreynaud yreynaud

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agrouaze @yreynaud