-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
major variables add (GradientFeatures) #86
Conversation
grdwindinversion/utils.py
Outdated
formatter = logging.Formatter( | ||
'%(asctime)s - %(name)s - %(levelname)s - %(message)s') | ||
console_handler.setFormatter(formatter) | ||
logger.addHandler(console_handler) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the rational of having 2 handlers rather than one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also changed in xsarsea to
logging.basicConfig(level=logging.INFO,
format='%(asctime)s - %(name)s - %(levelname)s - %(message)s')
logger = logging.getLogger('xsarsea')
we thought that inversion time was too long : sometimes 10 minutes for a EW I added a |
The test fails because the meta.yaml forces to xarray 2024.2.0. See the PR I just merged a few hours ago. To make this PR pass, you must reproduce these changes, by merge master or else |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For such large addition (heterogeneity mask) it would be good to have some unit tests, or at least one if it gives a large coverage for added methods.
unit tests associated will be added in another PR, #90
gradientFeatures.py
=> added heterogeneity mask (owiWindFilter) + 400VV & 800VH masks in xr_dataset
(Yuan Zhao 2021)
=> added work on streaks from gradients (Koch 2004) with mulitple polarisation/windows_size/resolutions results
=> added a documentation to plot streaks
inversion.py
=> started a work to have a logger
=> deleted some useless
.compute()
?! maybe less time for computation=> added
owiAncillaryNrcs
andowiAncillaryNrcs_cross
to simulate NRCS from ancillary wind using gmfconfig
=> small changes in the config file :
if not specified both are set to false
results saving
owiWindFilter (mask) + 4 temporar variables are added in the main group
a group is created for directions results :
owiWindStreaks
I also had to change RCM output format
changed RCM sensor_longname to fix Add full RCM mission to attributes #89