Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite loop when nesting elements #178

Closed
jchafik opened this issue Aug 6, 2018 · 1 comment
Closed

Infinite loop when nesting elements #178

jchafik opened this issue Aug 6, 2018 · 1 comment
Assignees
@ultraq
Labels
bug
Milestone
Thymeleaf Layout ...

Comments

@jchafik
Copy link

jchafik commented Aug 6, 2018

Starting in 2.3.0, nested elements are resulting in an infinite loop. Example:

<!DOCTYPE html SYSTEM "http://www.thymeleaf.org/dtd/xhtml1-strict-thymeleaf-spring4-4.dtd">
<html xmlns="http://www.w3.org/1999/xhtml"
      xmlns:layout="http://www.ultraq.net.nz/thymeleaf/layout"
      xmlns:th="http://www.thymeleaf.org">
<body>
  <div layout:fragment="comment">
    Comment structure
    <div layout:fragment="comment-details">Default comment details</div>
  </div>

  <div layout:include="~{::comment}">
    <div layout:fragment="comment-details">
      Top level comment
      <div layout:include="~{::comment}">
        <div layout:fragment="comment-details">Nested comment</div>
      </div>
    </div>
  </div>
</body>
</html>
@ultraq ultraq added the bug label Aug 7, 2018
@ultraq ultraq added this to the Layout Dialect 2.4 milestone Mar 21, 2019
@ultraq ultraq self-assigned this Mar 21, 2019
ultraq added a commit that referenced this issue Mar 25, 2019
@ultraq
Create test to replicate #178
6f7c68c
@ultraq ultraq closed this as completed in 34cb31d Mar 25, 2019
@ultraq
Copy link
Owner

ultraq commented Mar 25, 2019

Seems this got busted when #166 was added. Can't believe there wasn't a test to catch it, but there is now! Fix is now in 2.4.0-SNAPSHOT.

ultraq added a commit that referenced this issue Mar 25, 2019
@ultraq
Duplicate tests for insert & replace processors, #178
380cb9b
@ultraq ultraq mentioned this issue Mar 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ultraq ultraq

Labels
bug
Projects
None yet
Milestone
Thymeleaf Layout Dialect 2.4
Development

No branches or pull requests
2 participants
@jchafik @ultraq