All tags within <head> are pushed inside of <title> #144

xCJPECKOVERx · 2016-11-24T15:13:08Z

When using layout:decorate all tags within get put inside of the <title> tag as plain text. This includes scripts and links.
Results in a <title> such as:

<title> Exception Logs<script> $( document ).ready(function() { $('#errorSelect').on("change", function() { $(this).parents('form').submit(); }); }); </script> </title>

ultraq · 2016-11-25T05:08:17Z

Heya @xCJPECKOVERx, that's a really weird bug! To help me figure it out, would you be able to give a sample template & layout that can produce that kind of output? Also, what versions of the layout dialect and Thymeleaf are you using?

xCJPECKOVERx · 2016-11-25T17:07:00Z

Thymeleaf version: 3.0.2.RELEASE
LayoutDialect version: 2.1.1
I've managed to narrow down the bug to only happening when nesting layouts.
In my project I have a master (importing links and scripts), a header (decorated by master), and finally the content pages (decorated by the header).

Note: I'm also using Spring and have templateResolver, templateEngine, and viewResolver setup per Thymeleaf documentation and have added the LayoutDialect to the templateEngine.

master.html:

<html>
    <head>
        <title>default title</title>
    </head>
    <body>
        <div layout:fragment="page"></div>
    </body>
</html>

header.html:

<html layout:decorate="~{layouts/master}">
    <head></head>
    <body>
        <div layout:fragment="page">
            <a th:href="@{/home}">Home</a>
            <div layout:fragment="content"></div>
       </div>
    </body>
</html>

home.html:

<html layout:decorate="~{layouts/header}">
    <head>
        <title>Some Title</title>
        <script>alert('hello');</script>
    </head>
    <body>
        <div layout:fragment="content">
            <p>Some Content</p>
       </div>
    </body>
</html>

ultraq · 2016-11-28T08:49:49Z

Cool cool, managed to replicate it in the linked test/commit.

ultraq · 2016-11-29T10:31:44Z

I've had a look at it and found there was something wrong with the code I had that tried to insert what Thymeleaf 3 calls "models" (eg: an opening element, everything inside it, and the matching closing element) inside elements that are closed immediately, like your <head></head> tags. The code in question assumes that there's some whitespace around to duplicate (this is to create a cleaner-looking output) but without any it just inserts that <script> model into the wrong place.

The problem also appeared in the first decoration, so wasn't a multiple layouts issue.

I've uploaded a 2.1.2-SNAPSHOT version to Maven which has a fix for this. Could you give it a try in your project to see if it works for you?

xCJPECKOVERx · 2016-11-29T18:17:06Z

I've tried the fix and it does work. Good stuff!

ultraq · 2016-11-30T07:09:15Z

Awesome! I've got no other bugs to fix for now, so I'll get this into a release very soon.

ultraq added a commit that referenced this issue Nov 28, 2016

Test case for #144

5c47fcd

ultraq added the bug label Nov 28, 2016

ultraq closed this as completed in 3f9350c Nov 30, 2016

ultraq added a commit that referenced this issue Nov 30, 2016

Re-classify test for #144

0e89c7e

ultraq added a commit that referenced this issue Nov 30, 2016

Mention #144

745d7c7

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

All tags within <head> are pushed inside of <title> #144

All tags within <head> are pushed inside of <title> #144

xCJPECKOVERx commented Nov 24, 2016

ultraq commented Nov 25, 2016 •

edited

Loading

xCJPECKOVERx commented Nov 25, 2016

ultraq commented Nov 28, 2016

ultraq commented Nov 29, 2016

xCJPECKOVERx commented Nov 29, 2016

ultraq commented Nov 30, 2016

All tags within <head> are pushed inside of <title> #144

All tags within <head> are pushed inside of <title> #144

Comments

xCJPECKOVERx commented Nov 24, 2016

ultraq commented Nov 25, 2016 • edited Loading

xCJPECKOVERx commented Nov 25, 2016

ultraq commented Nov 28, 2016

ultraq commented Nov 29, 2016

xCJPECKOVERx commented Nov 29, 2016

ultraq commented Nov 30, 2016

ultraq commented Nov 25, 2016 •

edited

Loading