Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toy SAM/BAM files, add test for bam_parser.parse_bam_header #46

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

nwiltsie
Copy link
Member

@nwiltsie nwiltsie commented Nov 3, 2023

This adds a functional test for the parse_bam_header function.

For testing data I copied the tiny sample SAM file from the samtools GitHub repository (I added the origin link as a @CO record). I also created a duplicate with a @RG record, as that's the only thing parse_bam_header actually looks for! I turned the two SAM files into BAM files and commited the lot of them.

  • I have read the code review guidelines and the code review best practice on GitHub check-list.

  • I have reviewed the Nextflow pipeline standards.

  • The name of the branch is meaningful and well formatted following the standards, using [AD_username (or 5 letters of AD if AD is too long)]-[brief_description_of_branch].

  • I have set up or verified the branch protection rule following the github standards before opening this pull request.

  • I have added my name to the contributors listings in the
    metadata.yaml and the manifest block in the nextflow.config as part of this pull request, am listed
    already, or do not wish to be listed. (This acknowledgement is optional.)

  • I have added the changes included in this pull request to the CHANGELOG.md under the next release version or unreleased, and updated the date.

  • I have updated the version number in the metadata.yaml and manifest block of the nextflow.config file following semver, or the version number has already been updated. (Leave it unchecked if you are unsure about new version number and discuss it with the infrastructure team in this PR.)

  • I have tested the config being added or modified. Outline the tests below.

@nwiltsie nwiltsie requested review from tyamaguchi-ucla and a team as code owners November 3, 2023 16:40
@yashpatel6 yashpatel6 linked an issue Nov 7, 2023 that may be closed by this pull request
Copy link
Collaborator

@yashpatel6 yashpatel6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nwiltsie nwiltsie merged commit edfc2c2 into main Nov 7, 2023
2 checks passed
@nwiltsie nwiltsie deleted the nwiltsie_test_bam_parser branch November 7, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BAM parser - @nwiltsie
2 participants