Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alpha parameter to create.boxplot #41

Merged
merged 5 commits into from
Sep 23, 2022
Merged

Conversation

stefaneng
Copy link
Contributor

@lydiayliu This should fix the boxplot alpha parameter.

grDevices::adjustcolor is already imported by lattice.

Fixes #34

Copy link
Contributor

@dan-knight dan-knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just need to update NEWS and DESCRIPTION

@dan-knight dan-knight self-requested a review September 23, 2022 19:45
DESCRIPTION Outdated
@@ -1,5 +1,5 @@
Package: BoutrosLab.plotting.general
Version: 7.0.4
Version: 7.0.5
Type: Package
Title: Functions to Create Publication-Quality Plots
Date: 2022-03-15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the date here. (CRAN checks will fail if the date field is too far in the past.)

@@ -13,7 +13,8 @@ Authors@R: c(person("Paul Boutros", role = c("aut", "cre"), email = "PBoutros@me
person("Robert Gentleman", role = "ctb"),
person("Ross Ihaka", role = "ctb"),
person("Caden Bugh", role = "ctb"),
person("Dan Knight", role = "ctb"))
person("Dan Knight", role = "ctb"),
person("Stefan Eng", role = "ctb"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added you to the list of contributors.

@stefaneng stefaneng merged commit 83c7830 into main Sep 23, 2022
@stefaneng stefaneng deleted the stefaneng-34-boxplot-alpha branch February 2, 2023 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No option to make boxplot box colour transparent
2 participants