PXP-7807 Audit-service tests

[paulineribeyre]

Jira Ticket: PXP-7807

New Features

• Add tests for the audit-service integration with Fence: download and login events

Improvements

• Fix bug in indexd tasks "addFileIndices" function causing error messages "file is not defined"
• Refactor RAS client creation logic: remove code duplication, add error logs, and add a random string at the end of the client names to avoid "client already exists" issues
• Refactor "smartWait" function so that it doesn't wait for nothing at the end of the loop

[themarcelor]

Don't we want to make sure we have CI with diff mix-and-match of versions in cdis-manifest PRs?
We should be able to figure out whether audit-service is configured against a given environment by checking the manifest versions block and/or the portal/gitops.json.
Just checking, if you prefer this approach, that's ok.

[paulineribeyre]

sure

[atharvar28]

👍

[paulineribeyre]

Not ready to merge - I had to revert my Fence config changes in all the Jenkins environments because of "Audit logs are enabled but audit-service is unreachable" errors in cdis-manifest PRs without audit-service. Looking for a solution

[themarcelor]

@paulineribeyre , if you want to experiment further in the wild, you can just comment out the run-tests.sh logic and leave it as @donot '@audit', merge what you have so far and label specific PRs in gitops-qa and/pr cdis-manifest with "suites-apis-auditServiceTest" for further experimentation (or even label to select specific jenkins envs or even try that in ci-env-1 in qaplanetv2).

Of course, just a suggestion if you rather try iterative improvements / deliverables.

[paulineribeyre]

@themarcelor thanks - i think i'm "almost there" 🤞