implement ConsoleLogger for Scala.js #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AFAIK there's no legal entity called "Typelevel" that owns the copyright for these contributions, so it's a little unclear what these refer to 🤷
…sing ConsoleLoggerFactory
danicheg
reviewed
Oct 17, 2022
js-console/src/main/scala/org/typelevel/log4cats/console/Console.scala
Outdated
Show resolved
Hide resolved
js-console/src/main/scala/org/typelevel/log4cats/console/ConsoleLogger.scala
Outdated
Show resolved
Hide resolved
js-console/src/main/scala/org/typelevel/log4cats/console/ConsoleLoggerFactory.scala
Outdated
Show resolved
Hide resolved
armanbilge
reviewed
Dec 5, 2022
armanbilge
reviewed
Dec 5, 2022
js-console/src/main/scala/org/typelevel/log4cats/console/ConsoleF.scala
Outdated
Show resolved
Hide resolved
armanbilge
reviewed
Dec 5, 2022
js-console/src/main/scala/org/typelevel/log4cats/console/ConsoleLogger.scala
Outdated
Show resolved
Hide resolved
…now package-private
armanbilge
approved these changes
Dec 6, 2022
There was a problem hiding this comment.
LGTM from the JS side of things, I trust @danicheg on the log4cats side :)
Thanks so much for this!
|
So, I don't see any blockers to merge this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A basic implementation to close #680 and make logging available on Scala.js.