-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sequence InvariantMonoidals #246
Conversation
Hmm, that is interesting. Thanks for the PR 👍 |
Yes, ok, I wasn't sure how to take care of the binary incompatibility. I'll try what you suggest and update |
Ok, I've updated it. Seems like it's binary compatible now. I also added a few tests to test just the I'm not 100% sure that the way I've split things into different priorities is right. Please let me know if I've messed something up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The inheritance relation between MkHNilSequencerLowPrio
and MkHConsSequencerLowPrio
also has to be inverted.
Thanks for the contribution! This is really complex stuff, but the use case with Semigroup
looks really nice (although we already have derivation for that particular type class).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the changes because I'd like to merge and release 2.2.0 this weekend
Oh, thanks for merging this! My original motivation for this was to be able to write some appropriate typeclass instances for probability distributions. So you can define a However, with the previous code, this would only work if you had an Ideally I would write my tests in terms of |
I don't think we need
F[_]
to be anApplicative
to be able to sequence over it.InvariantMonoidal
is all we need.