Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a followup to #1952
In that, I used a binary tree to implement Chunk.traverse. This gives stack safety, but it doesn't make it faster. I observed later and noted in typelevel/cats#3517 that nothing requires the tree to be binary.
So, here, I use a tree with 128 children, and in all the internal nodes, I use
map2Eval
which allows short-circuiting and laziness for applicative instances that can avoid evaluating one side in some cases.This results in a significant speed-up over the foldRight based implementation:
note, fold failed with stack overflow for 4096 and 409600 so I couldn't compare them.