-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MonoidK and SemigroupK instances for Function1 and also a Semigroup instance for Function1 #691
Conversation
Current coverage is
|
new Function1MonoidK {} | ||
} | ||
|
||
trait Function1Instances0 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make this private[std] sealed trait Function1Instances0
please? This will make it consistent with the work done in #612.
I left a couple very minor comments, but other than that, this looks great! Thank you. |
Ok, that should do it :) |
👍 looks great! |
Thanks! 👍 |
Add MonoidK and SemigroupK instances for Function1 and also a Semigroup instance for Function1
This PR address #684 by adding MonoidK and SemigroupK instances for Function1; it also adds a Semigroup instance for Funcion1.