-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Future instances to implicit scope #3572
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3572 +/- ##
==========================================
- Coverage 91.33% 91.30% -0.03%
==========================================
Files 386 386
Lines 8612 8618 +6
Branches 265 262 -3
==========================================
+ Hits 7866 7869 +3
- Misses 746 749 +3 |
This should also resolve this #3536. Adding it for reference. |
We could remove
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Silly me :). The test changes are already in.
Reminder to self: never look at prs from the phone.
Once this is merged, it would be handy to have another RC release so I can bump the dependency in |
Yes, I'm traveling at the moment but could probably publish an RC tonight if this gets merged before then. |
@travisbrown Don't worry about it, I didn't realise we were publishing snapshots to Sonatype. I was able to use a snapshot. Enjoy your holiday! |
See discussion here. I've not built or run tests locally yet but I think it should work.