Add explicit type annotations for implicit Ordering vals #3188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dotty was complaining about some of these, so I went ahead and took care of all the
Ordering
ones.Now the only implicit vals in core without type annotations are things like
new OptionTMonad[F] { implicit val F = F0 }
, which Dotty is fine with. There are still a lot of others in cats-tests, which I'm not able to compile on Dotty yet because I don't have the laws modules working.The cases in this PR are all local definitions and they're a little more verbose, but personally seeing
implicit val whatever =
makes me anxious even in this context, and I think it's worth making this change even apart from the Dotty considerations.