Add Parallel instance for Ior #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnynek
reviewed
Dec 1, 2017
| (implicit E: Semigroup[E]): Parallel[Ior[E, ?], Ior[E, ?]] = new Parallel[Ior[E, ?], Ior[E, ?]] | ||
| { | ||
|
|
||
| def parallel: Ior[E, ?] ~> Ior[E, ?] = FunctionK.id |
There was a problem hiding this comment.
these could be val do avoid the reallocations, right?
| @@ -17,7 +16,7 @@ import scala.collection.immutable.SortedSet | |||
| class ParallelSuite extends CatsSuite with ApplicativeErrorForEitherTest { | |||
|
|
|||
There was a problem hiding this comment.
can we test the parallel laws?
/~https://github.com/typelevel/cats/blob/master/laws/src/main/scala/cats/laws/ParallelLaws.scala
| } | ||
| } | ||
| } | ||
| def monad: Monad[Ior[E, ?]] = Monad[Ior[E, ?]] |
| def parallel: Ior[E, ?] ~> Ior[E, ?] = FunctionK.id | ||
| def sequential: Ior[E, ?] ~> Ior[E, ?] = FunctionK.id | ||
|
|
||
| def applicative: Applicative[Ior[E, ?]] = new Applicative[Ior[E, ?]] { |
andyscott
force-pushed
the
parallel-ior
branch
from
ca555db to
d4f7d01
Compare
andyscott
commented
Dec 1, 2017
| } | ||
| } | ||
| } | ||
| lazy val monad: Monad[Ior[E, ?]] = Monad[Ior[E, ?]] |
There was a problem hiding this comment.
The monad instance isn't used for the parTraverse/parSequence use cases on Ior, so I've used a lazy val. All the other vals/defs are used.
andyscott
force-pushed
the
parallel-ior
branch
from
6d9a2b8 to
f920117
Compare
Codecov Report
@@ Coverage Diff @@
## master #2059 +/- ##
==========================================
+ Coverage 94.64% 94.66% +0.01%
==========================================
Files 318 318
Lines 5363 5379 +16
Branches 109 131 +22
==========================================
+ Hits 5076 5092 +16
Misses 287 287
Continue to review full report at Codecov.
|
|
👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
Parallelinstance forIor.The parallel instance is defined as
Parallel[Ior[E, ?], Ior[E, ?]]without any wrapper type for a "parallel Ior". We could add one, if it's useful.