Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

towncrier happily reads 1.feature.rst~, ignoring 1.feature.rst #101

Closed
njsmith opened this issue Dec 27, 2017 · 1 comment
Closed

towncrier happily reads 1.feature.rst~, ignoring 1.feature.rst #101

njsmith opened this issue Dec 27, 2017 · 1 comment

Comments

@njsmith
Copy link
Contributor

njsmith commented Dec 27, 2017

Another ugly bit of fallout from #65. Sorry.

I see two options:

  • Use git ls-files to find newsfragments, so we only pick up files that are actually under VCS

  • Instead of blindly accepting anything that looks like <anything>.<category>.*, let projects specify an extension in pyproject.toml and then only look for <anything>.<category>.<configured extension>
njsmith added a commit to njsmith/towncrier that referenced this issue Dec 27, 2017
@njsmith
Raise an error if a newsfragment collision is detected
05d5adf 
Currently (see twistedgh-101), if you have

  newsfragments/1.feature.rst
  newsfragments/1.feature.rst~

then towncrier will silently pick one of them essentially at random.
We should fix twistedgh-101 so that it picks the .rst one, not the .rst~ one,
but this would have been a lot easier to detect if towncrier had
pointed out that these collided. So let's check for that.
njsmith added a commit to njsmith/towncrier that referenced this issue Dec 27, 2017
@njsmith
Use git ls-files to find newsfragments
054c87b 
Fixes twistedgh-101.
@njsmith njsmith mentioned this issue Dec 27, 2017
Merged
@njsmith
Copy link
Contributor Author

njsmith commented Dec 27, 2017

On further thought, probably both of the options I said above are good ideas independently... #102 does the git ls-files thing because I am too lazy to figure out how to add a configuration option right now.

njsmith added a commit to njsmith/towncrier that referenced this issue Dec 30, 2017
@njsmith
Raise an error if a newsfragment collision is detected
843d15e 
Currently (see twistedgh-101), if you have

  newsfragments/1.feature.rst
  newsfragments/1.feature.rst~

then towncrier will silently pick one of them essentially at random.
We should fix twistedgh-101 so that it picks the .rst one, not the .rst~ one,
but this would have been a lot easier to detect if towncrier had
pointed out that these collided. So let's check for that.
njsmith added a commit to njsmith/towncrier that referenced this issue Dec 30, 2017
@njsmith
Raise an error if a newsfragment collision is detected
ee19853 
Currently (see twistedgh-101), if you have

  newsfragments/1.feature.rst
  newsfragments/1.feature.rst~

then towncrier will silently pick one of them essentially at random.
We should fix twistedgh-101 so that it picks the .rst one, not the .rst~ one,
but this would have been a lot easier to detect if towncrier had
pointed out that these collided. So let's check for that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@njsmith