Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed unnecessary badge and added relevant badges #995

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

tiwarishubham635
Copy link
Contributor

Fixes

Removed nodeio.co, twilioquest badges and added relevant badges for download counts and npm version

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@bnb
Copy link
Member

bnb commented Jan 22, 2024

looks like the npm version bade is breaking:
image

@tiwarishubham635
Copy link
Contributor Author

Hey @bnb! The seems to be working when I am looking at it. Maybe try clearing cache or opening from incognito browser?

@tiwarishubham635
Copy link
Contributor Author

But yeah there is some issue with this badge, since I am also seeing a 500 instead of version v4.20.1
Screenshot 2024-01-23 at 10 09 11 AM

@tiwarishubham635
Copy link
Contributor Author

Okay so I investigated over this. The image being rendered is being fetched from some third party API like badgen for npm version. The delay in response from there might cause the image to not render properly. However, the test badge is being used by a Github API only, so that should not break. However, I did saw that breaking as well at times. What is your suggestion? Should we look for other API or remove these badges?

@tiwarishubham635
Copy link
Contributor Author

Okay so I have removed the alt text that appears when badge is broken. So if the badge is broken, it won't show at all!

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@tiwarishubham635 tiwarishubham635 requested a review from bnb January 23, 2024 11:09
@tiwarishubham635
Copy link
Contributor Author

Hi @bnb! Please check the changes and if this looks good then we can proceed with this

@bnb
Copy link
Member

bnb commented Jan 23, 2024

Looks good to me.

@tiwarishubham635 tiwarishubham635 merged commit 163963e into main Jan 23, 2024
14 checks passed
@tiwarishubham635 tiwarishubham635 deleted the removing_badges branch January 23, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants