-
-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change name of Preferences > Filters > Tabs #3536
Comments
These options should also move to Account Preferences, a lot of users want to have different settings for different accounts. |
I would like to work on this task! |
That would be great! |
@sanao1006 I think it would involve adding two more columns to the And of course database migrations ( in |
Okay. Thanks for the info. I may ask questions if I don't understand something. I'll do my best. |
In the previous code, when you open preferences, there is a section headed "Filters" with a section called "Tabs" This is confusing. Therefore, make the following changes - Change the section title from "Filters" to "Per-timeline preferences." - Change the current "Tabs" section to "Home timeline" since it is only for home timelines Fixes tuskyapp#3536
Remove the following sharedPreferences as they are unnecessary. - TAB_FILTER_HOME_REPLIES - TAB_FILTER_HOME_BOOSTS - TAB_SHOW_HOME_SELF_BOOSTS Also, update sharedPreferences accordingly. Fixes tuskyapp#3536
…count Preferences(#3536) (#4115) # Overview In the previous code, when you open preferences, there is a section headed "Filters" with a section called "Tabs" This is confusing. # Changes - Change the section title from "Filters" to "Per-timeline preferences." - Change the current "Tabs" section to "Home timeline" since it is only for home timelines # Screenshots account preference screen | detail screen :--: | :--: |<image src="/~https://github.com/tuskyapp/Tusky/assets/62137820/12694f24-b7e3-4ba3-90f5-53740e9c4269" width="250" />|<image src="/~https://github.com/tuskyapp/Tusky/assets/62137820/796e9ac1-76d6-43ef-a087-a1cd2d899ef8" width="250" /> # Note - Maybe string resources should have a new property? (for translation) # Related link Fixes #3536 --------- Co-authored-by: mcc <andi.m.mcclure@gmail.com>
Open Preferences and there's a section with the heading "Filters", and the single entry "Tabs".
This is confusing, and I've just figured out why.
Proposed concrete change:
In the future, if other per-timeline options are needed (for example a "Show unread direct message count") then entries for those timelines can be added as additional sub-preference screens under here.
Tusky Version: 21
I searched or browsed the repo’s other issues to ensure this is not a duplicate.
The text was updated successfully, but these errors were encountered: