Respect allowed file types option #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baholladay
reviewed
Jul 30, 2024
view.php
Outdated
| $acceptedtypes = ['*']; | ||
| } | ||
| else { | ||
| $acceptedtypes = ['doc', 'docx', 'wpd', 'html', 'htm', 'ps', |
There was a problem hiding this comment.
where did this list of types come from?
There was a problem hiding this comment.
I created that list based on the guide found here: https://guides.turnitin.com/hc/en-us/articles/23929463501965-File-requirements
There is a list of file types in PP that I could copy from, but I am unsure whether we would have different allowed file types between the two plugins
There was a problem hiding this comment.
OK I figure it makes sense that they would be the same, so I have copied the list from the other plugin for now and pushed another commit
There was a problem hiding this comment.
please get Stephanie to confirm this list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we don't respect the 'Allow Submission of Any File Type' option. We are currently allowing submission of any file type regardless of whether this option is set or not.
I have added a list of file types to accept based on this guide: https://guides.turnitin.com/hc/en-us/articles/23929463501965-File-requirements
It is important that the list of accepted file extensions is accurate, so please could any reviewers check it and let me know if there are any that are wrong or any more I need to add.