New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add metadata registration macros #163

Merged

molpopgen merged 1 commit into main from metadata_registration

Sep 3, 2021

Member

molpopgen commented Sep 2, 2021

start on metadata registration macros
add registration + rountrip tests for json
test w/newtypes
add remaining macros and tests
restrict macro to feature set

molpopgen force-pushed the metadata_registration branch 3 times, most recently from 489da2e to 5848f1b Compare

September 3, 2021 20:09

juntyr reviewed

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

juntyr reviewed

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

juntyr reviewed

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

juntyr reviewed

View reviewed changes

src/metadata.rs Outdated Show resolved Hide resolved

juntyr reviewed

View reviewed changes

src/metadata.rs Show resolved Hide resolved

juntyr reviewed

View reviewed changes

src/metadata.rs Outdated Show resolved Hide resolved

juntyr reviewed

View reviewed changes

src/metadata.rs Outdated Show resolved Hide resolved

juntyr reviewed

View reviewed changes

src/metadata.rs Outdated Show resolved Hide resolved

juntyr reviewed

View reviewed changes

tskit-derive/src/lib.rs Show resolved Hide resolved

juntyr reviewed

View reviewed changes

tskit-derive/src/lib.rs Outdated Show resolved Hide resolved

juntyr reviewed

View reviewed changes

tskit-derive/src/lib.rs Outdated Show resolved Hide resolved

Member Author

molpopgen commented Sep 3, 2021

Thanks for the comments @MomoLangenstein. I didn't know about that "magic" overloading. I'd assumed it wouldn't work.

molpopgen force-pushed the metadata_registration branch from 6f60245 to 5ba2992 Compare

September 3, 2021 21:07

Contributor

juntyr commented Sep 3, 2021

Of course, always happy to help. I also didn’t actively know about them until very recently. This PR now definitely looks very good to me


          Add metadata type registration via derive macros.

bac59a3

molpopgen force-pushed the metadata_registration branch from 5ba2992 to bac59a3 Compare

September 3, 2021 21:13

Member Author

molpopgen commented Sep 3, 2021

I also didn’t actively know about them until very recently.

Neat! Gonna merge...

molpopgen merged commit 41633b6 into main

molpopgen deleted the metadata_registration branch

September 3, 2021 21:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet