Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding tables rows with metadata #131

Closed
molpopgen opened this issue Jul 21, 2021 · 0 comments
Closed

Adding tables rows with metadata #131

molpopgen opened this issue Jul 21, 2021 · 0 comments

Comments

@molpopgen
Copy link
Member

The various add_foo_with_metadata are a verbose API due to Option. For readability purposes, _with_metadata and Option don't quite align.

A fairly simple solution is to have a third (non-pub) fn that does the real work to handle the Option.
@molpopgen molpopgen mentioned this issue Jul 21, 2021
Merged
molpopgen added a commit that referenced this issue Jul 21, 2021
@molpopgen
Add additional member functions to TableCollection to
58c7b6b 
add rows with Some (non-Option-al) metadata.

Closes #131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@molpopgen