Differentiate postman folder from request when at collection root #3912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… info being identical to request info
casey-tran
commented
Feb 14, 2025
pkg/sources/postman/postman.go
Outdated
| @@ -350,17 +350,23 @@ func (s *Source) scanItem(ctx context.Context, chunksChan chan *sources.Chunk, c | |||
| if item.UID != "" { | |||
| metadata.FullID = item.UID | |||
| metadata.Link = LINK_BASE_URL + FOLDER_TYPE + "/" + metadata.FullID | |||
| metadata.FolderID = item.UID | |||
There was a problem hiding this comment.
This line is to handle the cases where the item that is going to be scanned is a folder itself that contains an auth or script. In that case, we want the FolderID to be of the target instead of the parent.
…unnecessary code and moved event call to after the type check
rosecodym
reviewed
Feb 14, 2025
| } | ||
|
|
||
| metadata.FolderID = item.UID |
There was a problem hiding this comment.
per convo, i think a comment here explaining all this parent folder ID business would be helpful
rosecodym
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When Postman items (mainly requests) did not have a parent folder and were at the root of a collection, the folder id/name would be the same as the request id/name. This change helps to keep track of the parent folder through the recursive calls and gives the folder ID of the last folder that the call went through.
Checklist:
make test-community)?make lintthis requires golangci-lint)?