-
-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
KATT
commented
Oct 7, 2023
•
edited
Loading
edited
- we can't know if a specific async type is done or not as it's the responsibility of the type itself
- we can know if a stream is interrupted prematurely, so I added a check for that
- we treat the "stream interrupted" as a message that we enqueue - if the interruption happens when the iterator has already consumed what it needs, we're all good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
try { | ||
controller.enqueue(err); | ||
} catch { | ||
// ignore if the controller is closed | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to get rid of this try/catch
🤷
} | ||
|
||
cache.clear(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't clear the cache because stuff can be listening