Implement interface boundaries #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move curveType into the mesh class to save after the mesh has been generated.
Some basic cleanup including zeroing the node acceleration and removing a redundant subroutine. Code still crashes on final smooth with interface boundaries.
at this point
Remove unused procedure.
All cleanup is moved out of the interface code and moved into the MeshCleaner code.
Modify logic on node release to remove nodes from the node list if the node list is the only object that references it. Also manually remove all the linked lists from the boundaryEdgesArray before releasing it. This seems to avoid an issue where waiting until the finalizer does it causes a crash in the interface routines. It also fixes an issue where unreferenced nodes appeared in the node list in the mesh file.
Prepare for adding the material name to an element if there are interface boundaries.
Instead of using an objectArray to store the pointers for the 4/8 element nodes, use an allocatable array of SMNodePtrs. This seems to avoid not the memory crash when using interface boundaries.
Move the setting of material IDs to the very end. Delete some unused code.
Material properties are only set if the ISM_MM output format is requested.
Remove redundant material setting code now covered in SetMaterialProperties
In several places execution was altered if non-fatal errors were present. Changes general catch to catch only on fatal exceptions.
BoneAndMarrow.control added to test suite.
The changes made don't generate unused nodes in the mesh. Other than that, the meshes are the same.
Codecov Report
@@ Coverage Diff @@
## main #53 +/- ##
==========================================
+ Coverage 68.00% 73.97% +5.97%
==========================================
Files 68 68
Lines 10275 10259 -16
==========================================
+ Hits 6987 7589 +602
+ Misses 3288 2670 -618
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
The documentation still needs to be updated before a merge. |
Add documentation on interface boundaries. Add BoneAndMarrow example. **The new added figure needs to be moved from the Figures directory to where all the other figures are stored in github and references changed in two places: Introduction and theModel**
sloede
requested changes
Apr 11, 2023
Fix typo in new addition to the documentation Co-authored-by: Michael Schlottke-Lakemper <michael@sloede.com>
andrewwinters5000
requested changes
May 19, 2023
There was a problem hiding this comment.
@DavidAKopriva I apologize for the extreme delay in my review. This slipped off my radar with all my teaching obligations.
This is a very cool new feature! Now we can create conforming interior/exterior object meshes for multi-material wave propagation problems. I left a few comments throughout. The main issue I found (also experimenting with the new feature locally on my machine) is that the background material name is not set properly in the resulting mesh file even when a MATERIALS block is present in the control file. I tried my best to track down where this bug could be.
Fixes two main issues with output of the mesh in the -MM format. 1. Fix the name of the background material keyword to "background material name" and check if it is set when the material key is present. If not, a warning is posted and the background material name is defaulted to "base" 2. Fix the output of the base material name by removing the "materialName" property from the element definition and printing the material name using the materialID of the element and the materialNameForIDs array held by the mesh. 3. Do #2 for hex meshes, too.
|
New figure for the docs. |
sloede
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nascent code is now implemented to mesh interior regions to allow for multiple material applications.