Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@uppy/thumbnail-generator: exifr: remove legacy IE support #3382

Merged
merged 1 commit into from
Jan 24, 2022
Merged

@uppy/thumbnail-generator: exifr: remove legacy IE support #3382

merged 1 commit into from
Jan 24, 2022

Conversation

arturi
Copy link
Contributor

@arturi arturi commented Dec 21, 2021 •
edited
Loading

We are patching the mini.umd.js because Vite (or ESBuild?) doesn't seem to support UMD files. We also used this opportunity to remove a bunch of stuff we are not using from Exifr. When switching to ESM, we could get rid of the patch file and directly import the necessary parts from Exifr.

To re-generate the file, clone Exifr repo, change line 230 of rollup.config.js to select "cjs" instead of "umd" and update src/bundles/mini.mjs to match the version in the patch.

@arturi arturi requested a review from aduh95 December 21, 2021 14:13
aduh95
aduh95 reviewed Dec 21, 2021
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bundle size is up from 158k to 159k, we probably want to find a way to bring that down before merging.

@Murderlon
Copy link
Member

I did some research on removing exifr entirely but it's less trivial than I thought. Still possible though

@arturi arturi mentioned this pull request Jan 4, 2022
Closed
@aduh95 aduh95 force-pushed the exifr-drop-legacy branch 2 times, most recently from fd623df to dc53167 Compare January 21, 2022 15:14
@aduh95 @arturi
@uppy/thumbnail-generator: exifr: remove legacy IE support
d561f39 
Co-authored-by: Artur Paikin <artur@arturpaikin.com>
@aduh95 aduh95 force-pushed the exifr-drop-legacy branch from dc53167 to d561f39 Compare January 21, 2022 15:15
@aduh95
Copy link
Contributor

aduh95 commented Jan 21, 2022

On main branch:

JS Bundle mingz:
  156500
CSS Bundle mingz:
   14059

With this change:

JS Bundle mingz:
  150358
CSS Bundle mingz:
   14059

@arturi arturi requested a review from Murderlon January 21, 2022 15:26
@arturi arturi merged commit ce950f3 into main Jan 24, 2022
@arturi arturi deleted the exifr-drop-legacy branch January 24, 2022 23:26
Murderlon added a commit that referenced this pull request Jan 31, 2022
@Murderlon
Merge branch 'main' into cypress
a42e2de 
* main:
  Upgrade size-limit to 7.0.5 (#3445)
  Unsplash: UI improvements (#3438)
  @uppy/thumbnail-generator: exifr: remove legacy IE support (#3382)
  Default to HEAD requests when the Companion looks to get meta information about a URL (#3417)
  check if info array is empty (#3442)
Murderlon added a commit that referenced this pull request Feb 1, 2022
@Murderlon
Merge branch 'main' into missing-types
a6eb595 
* main:
  Upgrade size-limit to 7.0.5 (#3445)
  Unsplash: UI improvements (#3438)
  @uppy/thumbnail-generator: exifr: remove legacy IE support (#3382)
  Default to HEAD requests when the Companion looks to get meta information about a URL (#3417)
  check if info array is empty (#3442)
  dev: fix Vite custom plugin (#3437)
  website: add legacy bundle to CDN example (#3433)
  meta: remove unused lerna and npm files (#3436)
  meta: replace browserify with esbuild (#3363)
  Release: uppy@2.4.1 (#3432)
  @uppy/transloadit: fix handling of Tus errors and rate limiting (#3429)
  Add Unsplash to website dashboard example (#3431)
@github-actions github-actions bot mentioned this pull request Feb 14, 2022
Merged
@aduh95 aduh95 mentioned this pull request Feb 14, 2022
Merged
github-actions bot pushed a commit that referenced this pull request Feb 14, 2022
@aduh95
Release: uppy@2.5.0 (#3487)
c3340a6 
| Package                   | Version | Package                   | Version |
| ------------------------- | ------- | ------------------------- | ------- |
| @uppy/companion           |   3.2.0 | @uppy/provider-views      |   2.0.7 |
| @uppy/companion-client    |   2.0.5 | @uppy/thumbnail-generator |   2.1.0 |
| @uppy/core                |   2.1.5 | @uppy/robodog             |   2.3.0 |
| @uppy/dashboard           |   2.1.4 | uppy                      |   2.5.0 |
| @uppy/locales             |   2.0.6 |                           |         |

- @uppy/companion: add support for COMPANION_UNSPLASH_SECRET (Mikael Finstad / #3463)
- @uppy/unsplash: fix nested meta (Artur Paikin / #3485)
- meta: fix(docs): typo in property `thumbnailType` (Dan Schalow / #3472)
- @uppy/robodog: add audio, box, unsplash, screen-capture to Robodog (Artur Paikin / #3483)
- meta: consolidate ENV files and fix contributing guidelines (Antoine du Hamel / #3475)
- @uppy/companion-client,@uppy/companion,@uppy/provider-views,@uppy/robodog: Finishing touches on Companion dynamic Oauth (Renée Kooi / #2802)
- meta: Improve companion docs (Mikael Finstad / #3479)
- meta: Make E2E Great Again (Merlijn Vos / #3444)
- meta: Add PostCSS handling to Vite (Artur Paikin / #3467)
- meta: Update CONTRIBUTING.md (Mikael Finstad / #3411)
- @uppy/companion: fix broken thumbnails for box and dropbox (Mikael Finstad / #3460)
- website: fix `Uppy is not defined` error (Antoine du Hamel / #3461)
- @uppy/companion: Implement periodic ping functionality (Mikael Finstad / #3246)
- @uppy/companion: fix callback urls (Mikael Finstad / #3458)
- @uppy/core,@uppy/dashboard,@uppy/thumbnail-generator: Add dashboard and UIPlugin types (Merlijn Vos / #3426)
- @uppy/locales: Add "save" to fr_FR.js (Charly Billaud / #3395)
- @uppy/companion: Fix TypeError when invalid initialization vector (Julian Gruber / #3416)
- meta: Upgrade size-limit to 7.0.5 (Artur Paikin / #3445)
- @uppy/provider-views: Unsplash: UI improvements (Artur Paikin / #3438)
- @uppy/thumbnail-generator: exifr: remove legacy IE support (Artur Paikin / #3382)
- @uppy/companion: Default to HEAD requests when the Companion looks to get meta information about a URL (Zack Bloom / #3417)
- @uppy/dashboard: check if info array is empty (Artur Paikin / #3442)
- meta: dev: fix Vite custom plugin (Antoine du Hamel / #3437)
- website: add legacy bundle to CDN example (Antoine du Hamel / #3433)
- meta: remove unused lerna and npm files (Antoine du Hamel / #3436)
- meta: replace browserify with esbuild (Antoine du Hamel / #3363)
HeavenFox pushed a commit to docsend/uppy that referenced this pull request Jun 27, 2023
@aduh95
Release: uppy@2.5.0 (transloadit#3487)
83148b2 
| Package                   | Version | Package                   | Version |
| ------------------------- | ------- | ------------------------- | ------- |
| @uppy/companion           |   3.2.0 | @uppy/provider-views      |   2.0.7 |
| @uppy/companion-client    |   2.0.5 | @uppy/thumbnail-generator |   2.1.0 |
| @uppy/core                |   2.1.5 | @uppy/robodog             |   2.3.0 |
| @uppy/dashboard           |   2.1.4 | uppy                      |   2.5.0 |
| @uppy/locales             |   2.0.6 |                           |         |

- @uppy/companion: add support for COMPANION_UNSPLASH_SECRET (Mikael Finstad / transloadit#3463)
- @uppy/unsplash: fix nested meta (Artur Paikin / transloadit#3485)
- meta: fix(docs): typo in property `thumbnailType` (Dan Schalow / transloadit#3472)
- @uppy/robodog: add audio, box, unsplash, screen-capture to Robodog (Artur Paikin / transloadit#3483)
- meta: consolidate ENV files and fix contributing guidelines (Antoine du Hamel / transloadit#3475)
- @uppy/companion-client,@uppy/companion,@uppy/provider-views,@uppy/robodog: Finishing touches on Companion dynamic Oauth (Renée Kooi / transloadit#2802)
- meta: Improve companion docs (Mikael Finstad / transloadit#3479)
- meta: Make E2E Great Again (Merlijn Vos / transloadit#3444)
- meta: Add PostCSS handling to Vite (Artur Paikin / transloadit#3467)
- meta: Update CONTRIBUTING.md (Mikael Finstad / transloadit#3411)
- @uppy/companion: fix broken thumbnails for box and dropbox (Mikael Finstad / transloadit#3460)
- website: fix `Uppy is not defined` error (Antoine du Hamel / transloadit#3461)
- @uppy/companion: Implement periodic ping functionality (Mikael Finstad / transloadit#3246)
- @uppy/companion: fix callback urls (Mikael Finstad / transloadit#3458)
- @uppy/core,@uppy/dashboard,@uppy/thumbnail-generator: Add dashboard and UIPlugin types (Merlijn Vos / transloadit#3426)
- @uppy/locales: Add "save" to fr_FR.js (Charly Billaud / transloadit#3395)
- @uppy/companion: Fix TypeError when invalid initialization vector (Julian Gruber / transloadit#3416)
- meta: Upgrade size-limit to 7.0.5 (Artur Paikin / transloadit#3445)
- @uppy/provider-views: Unsplash: UI improvements (Artur Paikin / transloadit#3438)
- @uppy/thumbnail-generator: exifr: remove legacy IE support (Artur Paikin / transloadit#3382)
- @uppy/companion: Default to HEAD requests when the Companion looks to get meta information about a URL (Zack Bloom / transloadit#3417)
- @uppy/dashboard: check if info array is empty (Artur Paikin / transloadit#3442)
- meta: dev: fix Vite custom plugin (Antoine du Hamel / transloadit#3437)
- website: add legacy bundle to CDN example (Antoine du Hamel / transloadit#3433)
- meta: remove unused lerna and npm files (Antoine du Hamel / transloadit#3436)
- meta: replace browserify with esbuild (Antoine du Hamel / transloadit#3363)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 left review comments

@Murderlon Murderlon Murderlon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arturi @Murderlon @aduh95