Update the error message and automatically download a dataset when a part of a recipe is not found #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e model download code commented out for now
dadmobile
reviewed
Jan 10, 2025
|
Yeah definitely |
…e model download code commented out for now
…thub.com/transformerlab/transformerlab-app into sanjay-fix-recipes-that-need-downloading
…well across os darkmode
…ownloadProgressBox
…certain downloads
dadmobile
requested changes
Jan 14, 2025
| if (!response.dataset.downloaded) { | ||
| msg += "Download dataset " + response.dataset.path | ||
| msg += "\n Download dataset " + response.dataset.path + ", this will be done automatically"; |
There was a problem hiding this comment.
I don't think we can automatically start these downloads without the user knowing what they are getting into? (even if we say this is just temporary)
My suggestion is:
- check if anything has to be downloaded. If so they show a confirm instead of an alert.
- If they click OK on the confirm THEN do the download.
There was a problem hiding this comment.
This should be done now.
Fixed the training status text when a failure occurs from success to failure
…thub.com/transformerlab/transformerlab-app into sanjay-fix-recipes-that-need-downloading
…on localhost. must improve before next release.
…e model download code commented out for now
…ownloadProgressBox
…certain downloads
…thub.com/transformerlab/transformerlab-app into sanjay-fix-recipes-that-need-downloading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change automatically downloads a dataset if a recipe requires one that is not downloaded, also this change contains commented code for model downloading that is not complete yet, but will be soon.