Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable expose of all docker containers #358

Closed
wants to merge 2 commits into from
Closed

Option to disable expose of all docker containers #358

wants to merge 2 commits into from

Conversation

s7anley
Copy link
Contributor

@s7anley s7anley commented May 7, 2016

In case someone wants to register containers manually.

@s7anley
Copy link
Contributor Author

s7anley commented May 7, 2016

@emilevauge I'm strangling with default value when configuration file is used. I didn't find the way how to configure viper. I tried viper.SetDefault, but this value is ignore once viper settings are loaded - configuration.go:304. Any ideas?

@emilevauge
Copy link
Member

@s7anley thanks for your contribution!
We are in the process of replacing viper/cobra by our own lib, it should be a lot easier to manage these use cases. I suggest we wait this refactor before merging your PR :)
WDYT?

@s7anley
Copy link
Contributor Author

s7anley commented May 13, 2016

Sure, not a problem.

@bbinet
Copy link
Contributor

bbinet commented May 25, 2016

+1, it would be great if it could be merged before 1.0 release.

@s7anley
Copy link
Contributor Author

s7anley commented May 25, 2016

@emilevauge any news regarding own configuration lib?

@emilevauge
Copy link
Member

The PR is here #403, will be merged soon :)

@emilevauge
Copy link
Member

Hi @s7anley, the PR #403 is merged ;)

@s7anley
Copy link
Contributor Author

s7anley commented May 27, 2016

@emilevauge thanks for update, I will take a look during weekend.

@emilevauge
Copy link
Member

Ping ?

@emilevauge
Copy link
Member

Hi @s7anley , I'm planning to get this PR in the 1.1 releases. Do you think it's possible ?

@vdemeester
Copy link
Contributor

Carrying here #514

@vdemeester vdemeester closed this Jul 11, 2016
@s7anley
Copy link
Contributor Author

s7anley commented Jul 12, 2016

Oh, I'm really sorry guys. Hopefully, next time I will do better work.

2016-07-11 23:02 GMT+02:00 Vincent Demeester notifications@github.com:

Closed #358 #358.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#358 (comment), or mute
the thread
/~https://github.com/notifications/unsubscribe/AAnEg5PqL4RI9S55QqMa0IKFWBY9LEIiks5qUq9cgaJpZM4IZbw8
.

@vdemeester
Copy link
Contributor

@s7anley don't worry about it, I'm just carrying it (and fixing conflicts), but it's still your work and your commit 😉. You did a good job 👍

emilevauge added a commit that referenced this pull request Jul 14, 2016
Carry #358 : Option to disable expose of all docker containers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants