Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix metrics problem on multiple entrypoints #2492

Merged
merged 1 commit into from
Nov 30, 2017

Conversation

juliens
Copy link
Member

@juliens juliens commented Nov 29, 2017

What does this PR do?

Fix a problem when we have multiple entrypoints
fixes #2489 #2368

Motivation

When we have multiple entrypoints, the metrics was collected only for the first entrypoint

More

  • Added/updated tests

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏 👏

Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmatur mmatur changed the title fix metrics problem on multiple entrypoints Fix metrics problem on multiple entrypoints Nov 30, 2017
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

@traefiker traefiker force-pushed the metrics-multiple-entrypoints branch from 0dec1f0 to 61cf92d Compare November 30, 2017 11:02
@traefiker traefiker merged commit 40b3c17 into traefik:v1.5 Nov 30, 2017
@juliens juliens deleted the metrics-multiple-entrypoints branch January 25, 2018 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants