Move http2 configure transport #2231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliens
force-pushed
the
fix-http2
branch
2 times, most recently
from
68724bd to
734a559
Compare
nmengin
reviewed
Oct 9, 2017
docs/user-guide/grpc.md
Outdated
| @@ -76,9 +76,12 @@ RootCAs = [ "./backend.cert" ] | |||
| rule = "Host:frontend.local" | |||
| ``` | |||
|
|
|||
| !!! warning | |||
| When using docker, the server URLs use the container ip, so you may need to configure `InsecureSkipVerify` instead of the `RootCAS` to activate https without hostname verification. | |||
|
|
|||
docs/user-guide/grpc.md
Outdated
| ## Conclusion | ||
|
|
||
| We don't need specific configuration to use gRPC in Træfik, we just need to be careful that all the exchanges (between client and Træfik, and between Træfik and backend) are valid HTTPS communications (without `InsecureSkipVerify` enabled) because gRPC use HTTP2. | ||
| We don't need specific configuration to use gRPC in Træfik, we just need to be careful that all the exchanges (between client and Træfik, and between Træfik and backend) are HTTPS communications because gRPC use HTTP2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http2.configureTransportwas called only when RootCAs are configured, certainly a problem during a resolve conflict