Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed numpy interface for surface derivative computation; added tests #1396

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

jnwalther
Copy link
Contributor

@jnwalther jnwalther commented Dec 8, 2024

Hi, I was made aware of a bug in the python interfaces for the numpy surface derivative computation, which made me realize that there were no tests. This PR fixes the error and supplements the tests.

Summary by Sourcery

Fix the numpy interface for surface derivative computation and add tests to validate curve and surface derivative evaluations.

Bug Fixes:

  • Fix the numpy interface for surface derivative computation by correcting the function signature to include an additional parameter.

Tests:

  • Add tests for curve and surface derivative evaluations to ensure correct functionality of the numpy interface.

Copy link

sourcery-ai bot commented Dec 8, 2024

Reviewer's Guide by Sourcery

This PR fixes a bug in the numpy interface for surface derivative computation and adds corresponding test coverage. The main change involves modifying the surface derivative evaluation method signature to include both u and v derivative parameters, along with new test cases for curve and surface derivative evaluation.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Modified the surface derivative evaluation interface to support both u and v derivatives
  • Added n_v parameter to eval_derivative_numpy_array method signature
  • Updated method to pass both n_u and n_v parameters to evalDerivativeNumpy
src/SWIG_files/common/ArrayMacros.i
Added comprehensive tests for curve and surface derivative evaluation
  • Added parametrized test for 2D and 3D curve derivative evaluation
  • Added test for surface derivative evaluation using a plane
  • Implemented verification of derivative vectors against geometric properties
test/test_core_numpy.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jnwalther - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@tpaviot
Copy link
Owner

tpaviot commented Dec 9, 2024

👍

@tpaviot tpaviot merged commit 5e914bd into tpaviot:master Dec 9, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants