Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AddAuthorization middleware #95

Merged
merged 5 commits into from
Jun 23, 2021
Merged

Add AddAuthorization middleware #95

merged 5 commits into from
Jun 23, 2021

Conversation

davidpdrsn
Copy link
Member

@davidpdrsn davidpdrsn commented May 21, 2021

This is the client counterpart to RequireAuthorization. It sets the
Authorization with basic or bearer token auth. Its meant to be
straight forward to use and if someone has a more complex use case
they can use SetRequestHeader instead which is more flexible.

TODO:

  • Update changelog

This is the client counterpart to `RequireAuthorization`. It sets the
`Authorization` with basic or bearer token auth.
@davidpdrsn davidpdrsn added the A-new-middleware Area: new middleware proposals label May 21, 2021
@davidpdrsn davidpdrsn requested review from tobz and LucioFranco May 21, 2021 12:49
Copy link
Contributor

@tesaguri tesaguri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor nits.

@davidpdrsn davidpdrsn merged commit 8779a39 into master Jun 23, 2021
@davidpdrsn davidpdrsn deleted the add-authorization branch June 23, 2021 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-new-middleware Area: new middleware proposals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants