-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix #903] Fix deprecation warning in LogSubscriber in Rails 7.1 #907
Conversation
Great, thank you for the PR, could you please update the change log as well? Thank you! Something like this /~https://github.com/toptal/chewy/pull/892/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR7. Once CI pass, I guess I'm fine with merge. |
9c310f0
to
8bbd11b
Compare
@konalegi I've squashed the changes with the The 7.1 builds were failing because of this: As it was unable to require Let me know what you think 👍 |
But please, fix a minor issue that I've commented in your PR |
7dbe1bf
to
c50b58e
Compare
@konalegi Changes done 👍 I think you have to trigger the workflows. Let's see what happens |
It doesn't work and makes total sense, as it is needed to load the deprecators, depending the version one or another. If today I have time, I will take a deeper look and come back to you. |
…ng to Rails 7.1
c50b58e
to
57fa8bc
Compare
@konalegi I was looking for the same error in other gems. Based on what CocoaPods did and the official documentation, I believe requiring the bare minimum with |
@alejandroperea I'll take a look, I don't know what exactly adds |
Sure @konalegi , no hurries! What I understand from the documentation, it only loads the bare minimum and some entry points for being able to load then the needed extensions, but not 100% sure. Now the tests are passing. Let me know if you need further changes or investigation 👍 |
@@ -1,3 +1,4 @@ | |||
require 'active_support' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm, it's pretty safe https://guides.rubyonrails.org/active_support_core_extensions.html#stand-alone-active-support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you!
I'll try to gather 2nd review, if not, will merge later. |
Thanks for checking it @konalegi ! |
released in https://rubygems.org/gems/chewy/versions/7.3.5 |
Thank you so much @konalegi ! |
…ng to Rails 7.1 (toptal#907)
…ng to Rails 7.1 (toptal#907)
Fixes #903
color
method was changed in Rails 7.1, introducing amode_options
hash instead of a position parameter just for bold option.This PR checks the ActiveSupport version and calls
color
method with the proper parameters.Also, I've added the configuration for executing the CI for Rails 7.1 version
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).