chore: backport changes since October 1st, 2023 #2794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, link points to an outdated version. Make the link point to latest released version
## Motivation `NonBlocking` from `tracing-appender` wraps a writer and requires that writer to implement `Sync` (among other bounds). However it is not clear why this bound is necessary in first place: this writer is sent to a dedicated thread and never used directly concurrently. #1934 demonstrates that it is a real problem for some people. Also at my current work we hit this issue as well when a third-party writer did not implement `Sync`. Our workaround was to wrap that writer in our own type and manually implement `Send` and `Sync` for it. Needless to say that it is more a hack than a proper solution. ## Solution Remove `Sync` bound in relevant places. Yep, that simple. Probably having it in first place was just an oversight. Closes #1934
These docs were updated (in response to #1669), but the "or equal to" phrase should have been moved to the other case. Fixes: #1993 ## Motivation When these docs were updated in response to #1669, they were updated incompletely (a level that is equal to a filter is _enabled_, not _disabled_) and therefore remained incorrect. ## Solution The docs were updated, moving the "or equal to" phrase to the other case.
When a user has a crate named `core`, it can cause issues because our crates import from `::core::*`. Now we are importing from `$crate::__macro_support::*` and there will be no more name clashes.
The `from_env` and `try_from_env` methods on the builder had the same documentation. This change updates their docs to correctly describe their difference in behavior. ## Motivation Make the docs more clear, so that users need not look at the source to understand the difference between these two functions. ## Solution Updated the docs Co-authored-by: Eliza Weisman <eliza@buoyant.io>
When using a function annotated with `#[instrument]` it parses the parameters of the function and records them either using `Value` or using `std::fmt::Debug`. There were a few types that implement `Value` but were missing the RecordTypes array. Added them + a unit test for a single one. Fixed: #2775
davidbarsky
changed the title
davidbarsky
force-pushed
the
david/backport-11-06-2023
branch
2 times, most recently
from
459b8bb to
f9c577d
Compare
davidbarsky
added a commit
that referenced
this pull request
Nov 7, 2023
davidbarsky
force-pushed
the
david/backport-11-06-2023
branch
from
f9c577d to
7ffc14a
Compare
davidbarsky
added a commit
that referenced
this pull request
Nov 7, 2023
davidbarsky
force-pushed
the
david/backport-11-06-2023
branch
from
7ffc14a to
92b5e68
Compare
davidbarsky
force-pushed
the
david/backport-11-06-2023
branch
from
92b5e68 to
82d439f
Compare
hawkw
approved these changes
Nov 7, 2023
This was referenced Nov 7, 2023
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this pull request
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of last month's commits from master.
(The set of commits I needed to backport were generated using
patcher ~/Developer/tracing "2023-10-01 00:00:00" --destination="v0.1.x. I'm happy with that CLI.)