Ipxe hot fix #450
Merged
Ipxe hot fix #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The iPXE kernel and initrd retries didnt work. This fixes them and adds a configurable retry delay. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
jacobweinstock
added
kind/bug
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #450 +/- ##
===================================
- Coverage 69% 69% -1%
===================================
Files 16 16
Lines 1389 1392 +3
===================================
+ Hits 960 962 +2
- Misses 402 403 +1
Partials 27 27 ☔ View full report in Codecov by Sentry. |
|
hmm....looks like GitHub Actions are having issues. https://www.githubstatus.com/ |
chrisdoherty4
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The iPXE kernel and initrd retries didnt work. This fixes them and adds a configurable retry delay.
Why is this needed
Fixes: #
How Has This Been Tested?
Tested via manual deployment and network booted a machine.
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: