Remove toolchain from go.mod #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes ci issues. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Without this newer Go versions are used and are causing changes to go.mod Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #440 +/- ##
===================================
Coverage 69% 69%
===================================
Files 16 16
Lines 1386 1386
===================================
Hits 958 958
Misses 401 401
Partials 27 27 ☔ View full report in Codecov by Sentry. |
|
Does this change represent a general recommendation? |
chrisdoherty4
approved these changes
Apr 30, 2024
No. Was just trying to get CI working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This causes ci and dependabot issues. Also needed to use the
shell.nixfile in the CI "Fetch Deps" or newer versions of Go get used and cause changes to the go.mod.Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: