*: enable errcheck for schedulers #8322
Conversation
Signed-off-by: Ryan Leung <rleungx@gmail.com>
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
| @@ -207,6 +207,6 @@ issues: | |||
| - path: (pd-analysis|pd-api-bench|pd-backup|pd-ctl|pd-heartbeat-bench|pd-recover|pd-simulator|pd-tso-bench|pd-ut|regions-dump|stores-dump) | |||
| linters: | |||
| - errcheck | |||
| - path: (pkg/tso/admin.go|pkg/schedule/schedulers/split_bucket.go|server/api/plugin_disable.go|server/api/plugin_disable.go|server/api/operator.go|server/api/region.go|pkg/schedule/schedulers/balance_leader.go|server/api/.*\.go|pkg/replication/replication_mode.go|pkg/storage/endpoint/gc_safe_point.go|server/.*\.go|pkg/schedule/schedulers/.*\.go|pkg/syncer/server.go) | |||
| - path: (pkg/tso/admin.go|pkg/schedule/schedulers/split_bucket.go|server/api/plugin_disable.go|server/api/plugin_disable.go|server/api/operator.go|server/api/region.go|pkg/schedule/schedulers/balance_leader.go|pkg/replication/replication_mode.go|pkg/storage/endpoint/gc_safe_point.go|server/.*\.go|pkg/syncer/server.go) | |||
There was a problem hiding this comment.
Are there any of these files still unassigned?
There was a problem hiding this comment.
Only tools left, but perhaps unnecessary for some of them.
There was a problem hiding this comment.
This pr(#8317) enable most of files. You can check it
|
@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
rleungx
added
require-LGT1
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
/merge |
|
@rleungx: We have migrated to builtin 👉 Please use
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: HuSharp, lhy1024, okJiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: Ref #1919.
What is changed and how does it work?
Check List
Tests
Release note