Fix Octane caching issue #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My original PR to improve Ziggy's performance on Octane, #417, turned out to be a bit overzealous—it cached the entire
Ziggyinstance, including the base URL and any configured groups. While the routes don't change between requests, the app URL can, as described in #457.Another issue I noticed looking into this is that the
$grouppassed to Ziggy can also change, not only between requests but even in the same request if the Blade directive is used in different places, so we can't cache that either.This PR reverts #417 and tackles caching in a slightly different way, doing it inside the
Ziggyclass and only caching the list of named routes and nothing else.Closes #457.