Allow routing to apps installed in subfolders #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakerkretzmar
added a commit
that referenced
this pull request
Jun 26, 2020
bakerkretzmar
added a commit
that referenced
this pull request
Jul 31, 2020
* Formatting * Clarify and shorten test names * Fix assertion parameter order – `assert.equal` wants actual first, then expected * Run tests with AVA instead of Mocha * Move tests related to checking the current route into their own file * Add test for regex bux * Update port test * Remove unnecessary setup * Rename test.route.js to route.spec.js * Extract common setup steps * Move axios tests into their own file * Move check tests into their own file * Wip * Consolidate setup * Update PHP testing configuration * Remove unused methods and imports * Require phpunit explicitly * Add test from #263 * Naming and formatting, and splitting more tests out into their own files * Load test routes from fixture file * Make assertions stricter * Make assertions stricter and clean up formatting * Define routes in setUp again * Formatting * Formatting * Formatting * Wip * Finish converting JS tests * Add tests from #302 for subfolder routing * Add tests from #301 for parsing the id key out of an object * Remove arrow functions for compatibility with PHP < 7.4 * Update dependencies * Clean up repetitive assertions * Formatting * Stub out tests for open PRs * Stub out test for matching current route *with parameters* * Remove babel Object.assign transform * Simplify Ava config * Update deps and format babel config * Clean up setup a bit * Clean up PHP test formatting * Simplify filtering * Correctly set latest tag during `npm publish` even if it isn't annotated * Move all tests back into one file * Remove axios tests * Use power-assert * Rename back to route.test.js * Use Jest * Update Contributing and test workflow * Formatting * Remove build:watch * Formatting * Formatting * Fix globals * Fix middleware test on Laravel <7 * Update changelog * PHPUnit and PHP version * Remove dumps * Don't test PHP 7.2 * Wip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tweaks how Ziggy parses the
pathnameof the current URL so that it's possible to use Ziggy with Laravel apps installed in subfolders. Fixes #295.Rather than just using
window.location.pathnamedirectly, and calling.slice(1)to remove the leading slash, I'm now getting the pathname, getting Ziggy'sbaseUrland parsing out anything after the domain name, and then comparing these to see if we need to trim the subfolder segment off the beginning of the pathname.