-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
overhaul of the chord parser #931
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changes to the parser
… for the given patterns
yaxu
approved these changes
Jul 27, 2022
Looks good! |
Ready for merge? |
Yes! |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to make this working, i had to change TPat to a generalised ADT to add a node for TPat_Chord that essentialy has three fields, one for each component of a chord: a
TPat a
wherea
is some Num type, aTPat String
for chord names and a[TPat [Modifier]]
for modifiers. Due to some type trickery there is an additional field for making TPats instance of Functor (this is essentially the yoneda lemma applied, kind of like here https://stackoverflow.com/questions/17157579/functor-instance-for-a-gadt-with-type-constraint)motivation for these changes was mainly this thread: https://club.tidalcycles.org/t/rfc-working-on-making-chord-naming-chordlist-more-consistent/2717/64
leaving the technical details behind, what these changes result in is a better seperation of syntax and semantics of chords, i.e., there is a corresponding semantic function
chord :: Num a => Pattern a -> Pattern String -> [Pattern [Modifier]] -> Pattern a
further, every field in chords is patternable now and modifiers can be stacked
it should also be easy now to define new modifiers very quickly (like I did for the new drop modifier)
i also introduced two new functions
collect :: Pattern a -> Pattern [a]
anduncollect :: Pattern [a] -> Pattern a
that collect/stack all events that have the exact same duration