-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ShellPkg: DXE_ASSERT when issuing drvcfg command in UEFI Shell #10627
Conversation
With this change, drvcfg will output help message when no input is specified? |
It seems the command
|
According to UEFI Shell spec, please make sure this command works. To display the list of devices that are available for configuration: |
Just in case, this patch is an improvement compared to the current state where |
Agree this change is better than before. |
20b429b
to
d2a19bb
Compare
Otherwise lgtm aswell |
REF: tianocore#10626 Issue command drvcfg directly, system halt Signed-off-by: "Zhu, Cliff" <Cliff.zhu@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
Fixes #10626
Issue command drvcfg derectly, system halt
Cc: Liming Gao gaoliming@byosoft.com.cn
Reviewed-by: Liming Gao gaoliming@byosoft.com.cn
Description
<Include a description of the change and why this change was made.>
<For each item, place an "x" in between
[
and]
if true. Example:[x]
(you can also check items in GitHub UI)><Create the PR as a Draft PR if it is only created to run CI checks.>
<Delete lines in <> tags before creating the PR.>
How This Was Tested
<Describe the test(s) that were run to verify the changes.>
Integration Instructions
<Describe how these changes should be integrated. Use N/A if nothing is required.>