Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShellPkg: DXE_ASSERT when issuing drvcfg command in UEFI Shell #10627

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

zhurui22
Copy link
Contributor

@zhurui22 zhurui22 commented Jan 15, 2025

Fixes #10626

Issue command drvcfg derectly, system halt

Cc: Liming Gao gaoliming@byosoft.com.cn
Reviewed-by: Liming Gao gaoliming@byosoft.com.cn

Description

<Include a description of the change and why this change was made.>

<For each item, place an "x" in between [ and ] if true. Example: [x] (you can also check items in GitHub UI)>

<Create the PR as a Draft PR if it is only created to run CI checks.>

<Delete lines in <> tags before creating the PR.>

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

<Describe the test(s) that were run to verify the changes.>

Integration Instructions

<Describe how these changes should be integrated. Use N/A if nothing is required.>

@lgao4
Copy link
Contributor

lgao4 commented Jan 16, 2025

With this change, drvcfg will output help message when no input is specified?

@pierregondois
Copy link
Contributor

With this change, drvcfg will output help message when no input is specified?

It seems the command drvcfg alone is valid, so it might not be necessary to output help message.
However issuing drvcfg -c doesn't output anything for me even though all devices and child devices should be printed out.

To display the list of devices that are available for configuration:
Shell> drvcfg
To display the list of devices and child devices that are available for configuration:
Shell> drvcfg –c

@lgao4
Copy link
Contributor

lgao4 commented Jan 17, 2025

drvcfg

According to UEFI Shell spec, please make sure this command works.

To display the list of devices that are available for configuration:
Shell> drvcfg
To display the list of devices and child devices that are available for configuration:
Shell> drvcfg -c

@pierregondois
Copy link
Contributor

With this change, drvcfg will output help message when no input is specified?

It seems the command drvcfg alone is valid, so it might not be necessary to output help message. However issuing drvcfg -c doesn't output anything for me even though all devices and child devices should be printed out.

To display the list of devices that are available for configuration:
Shell> drvcfg
To display the list of devices and child devices that are available for configuration:
Shell> drvcfg –c

Just in case, this patch is an improvement compared to the current state where drvcfg -c crashes,
it's just that it would be even better to have a command doing something usefull.

@lgao4 lgao4 added the push Auto push patch series in PR if all checks pass label Jan 23, 2025
@lgao4
Copy link
Contributor

lgao4 commented Jan 23, 2025

With this change, drvcfg will output help message when no input is specified?

It seems the command drvcfg alone is valid, so it might not be necessary to output help message. However issuing drvcfg -c doesn't output anything for me even though all devices and child devices should be printed out.

To display the list of devices that are available for configuration:
Shell> drvcfg
To display the list of devices and child devices that are available for configuration:
Shell> drvcfg –c

Just in case, this patch is an improvement compared to the current state where drvcfg -c crashes, it's just that it would be even better to have a command doing something usefull.

Agree this change is better than before.

@zhurui22 zhurui22 force-pushed the zr branch 6 times, most recently from 20b429b to d2a19bb Compare January 23, 2025 09:04
@pierregondois
Copy link
Contributor

The commit message format is not valid:
 * First line of commit message (subject line) is too long (92 >= 76).

Otherwise lgtm aswell

REF: tianocore#10626

Issue command drvcfg directly, system halt

Signed-off-by: "Zhu, Cliff" <Cliff.zhu@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
@mergify mergify bot merged commit 3330973 into tianocore:master Jan 24, 2025
126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: <title> DXE_ASSERT when issuing drvcfg command in UEFI Shell
3 participants