Refactor and reorganize #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
========================================
Coverage 0 0.00%
========================================
Files 0 20 +20
Lines 0 1196 +1196
========================================
- Misses 0 1196 +1196
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Merged
anttimaki
reviewed
Nov 8, 2022
There was a problem hiding this comment.
Been a year since I've worked with this code base so there's no deep insights in my comments.
I also noticed that sometimes braces were used around if statements and other times weren't. Can't quite recall if the codebase preferred one approach over the other, but if it does, it would be preferable to stick to it.
anttimaki
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't contain any logic changes, is instead changes to names and file locations.
Also contains a switch to Newtonsoft and Tomlet instead of System.Text.Json and Tommy. These pieces behave the same as previously.