Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting to automatically expand taglines #1606

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented Nov 27, 2024

Pull Request Description

This PR adds a new setting under General -> Feed which allows taglines to be automatically expanded. I've also defaulted taglineIsLong to be true as I noticed long taglines cause a weird animation as it transitions from expanded -> collapsed when initially loading the feed.

Issue Being Fixed

Issue Number: Feature request from the Thunder Lemmy community: https://lemmy.world/post/22153408

Screenshots / Recordings

Simulator.Screen.Recording.-.iPhone.16.Plus.-.2024-11-26.at.20.18.49.mp4

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Something else you could do is change the threshold at which we determine a tagline to be long so that, even without this new setting enabled, people are more likely to see full taglines without having to expand.

@hjiangsu
Copy link
Member Author

I've doubled the height threshold for determining long taglines - ideally, this should translate to seeing at most 2 lines of text before the tagline is considered too long (but won't always be the case due to per-device font sizing).

Let me know if this works!

@micahmo
Copy link
Member

micahmo commented Nov 27, 2024

That sounds good!

@hjiangsu hjiangsu merged commit c7050a1 into develop Nov 27, 2024
1 check passed
@hjiangsu hjiangsu deleted the feature/enable-expanded-taglines branch November 27, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants