Link "How to"^W^WGuides" section from navigation #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](/~https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -19,6 +19,6 @@ | |||
| root to: "customers#index" | |||
| end | |||
|
|
|||
| get "/:page", to: "docs#show" | |||
| get "/*page", to: "docs#show" | |||
There was a problem hiding this comment.
Rails/HttpPositionalArguments: Use keyword arguments instead of positional arguments for http call: get.
There was a problem hiding this comment.
Hound appears to think that this is a test, but it isn't...
pablobm
changed the title
pablobm
changed the title
nickcharlton
force-pushed
the
guides-section
branch
from
0f13eeb to
1d30a42
Compare
nickcharlton
force-pushed
the
guides-section
branch
from
1d30a42 to
5961d31
Compare
|
I'm going to merge this anyway, but a parting thought: Guides might be a good subheading to split the other Docs for the more advanced things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new "How to" section is not yet linked from the sidebar navigation in the documentation site. This PR: