Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Generic OAuth Provider #138

Merged
merged 8 commits into from
Jun 29, 2020
Merged

Add Generic OAuth Provider #138

merged 8 commits into from
Jun 29, 2020

Conversation

thomseddon
Copy link
Owner

@thomseddon thomseddon commented Jun 28, 2020 •
edited
Loading

As discussed in #91

TODO:

  • Test with gitea
  • Test with github

@thomseddon thomseddon added the enhancement New feature or request label Jun 28, 2020
@thomseddon thomseddon added this to the 2.2 milestone Jun 28, 2020
@thomseddon thomseddon mentioned this pull request Jun 28, 2020
Closed
@thomseddon thomseddon mentioned this pull request Jun 28, 2020
Closed
@thomseddon
Copy link
Owner Author

Tested working with both gitea and github 🎉

This does depend on #141 as github uses an int user id, which causes an error

@thomseddon thomseddon merged commit 9e5994b into master Jun 29, 2020
@thomseddon thomseddon deleted the feature/generic-oauth-provider branch June 29, 2020 20:04
thomseddon added a commit that referenced this pull request Aug 22, 2020
@thomseddon
Add Generic OAuth Provider (#138)
35f99fa
thomseddon added a commit that referenced this pull request Aug 22, 2020
@thomseddon
Add Generic OAuth Provider (#138)
111be2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@thomseddon @SuperSandro2000