Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify that SW components can be both code and config #74

Merged
merged 3 commits into from
Feb 9, 2023
Merged

clarify that SW components can be both code and config #74

merged 3 commits into from
Feb 9, 2023

Conversation

thomas-fossati
Copy link
Owner

Fix #72

@thomas-fossati
Update ref to the RATS architecture RFC
c410dc0 
Signed-off-by: Thomas Fossati <thomas.fossati@arm.com>
@thomas-fossati
Fix #72
0585f14 
Signed-off-by: Thomas Fossati <thomas.fossati@arm.com>
adrianlshaw
adrianlshaw reviewed Feb 9, 2023
View reviewed changes
Copy link
Collaborator

@adrianlshaw adrianlshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to introduce measurement types on line ~450 to help illustrate separation of code measurements from config measurements? Like "BL-config" or "PRoT-config"?

@thomas-fossati
provide example labels for config measurements
fb9e8f8 
Signed-off-by: Thomas Fossati <thomas.fossati@arm.com>
@thomas-fossati
Copy link
Owner Author

Do we want to introduce measurement types on line ~450 to help illustrate separation of code measurements from config measurements? Like "BL-config" or "PRoT-config"?

done in fb9e8f8

@adrianlshaw adrianlshaw self-requested a review February 9, 2023 18:49
adrianlshaw
adrianlshaw approved these changes Feb 9, 2023
View reviewed changes
Copy link
Collaborator

@adrianlshaw adrianlshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, LGTM!

@thomas-fossati thomas-fossati merged commit ae4b682 into master Feb 9, 2023
@thomas-fossati thomas-fossati deleted the issue-72 branch February 9, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianlshaw adrianlshaw adrianlshaw approved these changes

@hannestschofenig hannestschofenig Awaiting requested review from hannestschofenig

@SimonFrost-Arm SimonFrost-Arm Awaiting requested review from SimonFrost-Arm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

software components and configuration
2 participants
@thomas-fossati @adrianlshaw