Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use inherits instead of class(x) == #275

Merged
merged 2 commits into from
Apr 12, 2020
Merged

use inherits instead of class(x) == #275

merged 2 commits into from
Apr 12, 2020

Conversation

zkamvar
Copy link
Collaborator

@zkamvar zkamvar commented Mar 23, 2020

This is a fix for R 4.0. It was never previously caught because this part of the code has not been tested.

romunov
romunov reviewed Mar 23, 2020
View reviewed changes
Copy link
Collaborator

@romunov romunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe adding a test would also be prudent?

@zkamvar
Copy link
Collaborator Author

zkamvar commented Mar 27, 2020

Maybe adding a test would also be prudent?

Yes, you are correct!

@zkamvar zkamvar merged commit 1ad16e3 into master Apr 12, 2020
@zkamvar zkamvar deleted the znk-class-fix branch April 12, 2020 23:01
@zkamvar zkamvar mentioned this pull request May 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romunov romunov romunov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zkamvar @romunov