ci: include eslint matrix #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Belco90
added
the
chore
timdeschryver
approved these changes
Jun 13, 2020
gndelia
approved these changes
Jun 13, 2020
|
Nice one!! 🚀 |
@timdeschryver As I have defined a matrix for tests, I don't want a matrix for the release but a single stage with specific node and ESLint versions. I think I got it properly defined in the config, but we will see when merging this 😅 |
|
Yes! Working as desired: matrix for testing, single stage for release |
|
🎉 This PR is included in version 3.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update CI matrix to run tests combining supported node versions (v10.12, v12, v14) and ESLint versions (v5, v6). This will help adding support for ESLint v7 in #139
I'm not sure how to test or dry run the release stage, so I may need to readjust something when this PR is merged (unless someone can help me testing this locally).