Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adding keys with different roles #230

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

sethterashima
Copy link
Collaborator

Previously, the API only allowed adding keys with the Owner or Driver roles. This expands the API to allow keys with other roles. See pkg/protocol/protocol.md for documentation on the different roles.

Description

Please include a summary of the changes and the related issue.

Fixes #217

Type of change

Please select all options that apply to this change:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Checklist:

Confirm you have completed the following steps:

  • My code follows the style of this project.
  • I have performed a self-review of my code.
  • I have made corresponding updates to the documentation.
  • I have added/updated unit tests to cover my changes.

Previously, the API only allowed adding keys with the Owner or Driver
roles. This expands the API to allow keys with other roles. See
pkg/protocol/protocol.md for documentation on the different roles.
@sethterashima sethterashima merged commit 9d11f68 into teslamotors:main Apr 11, 2024
1 check passed
@erikgieseler
Copy link

I have just tried out the "charging_manager" role:
The commands: charging-start, charging-stop and charging-set-amps work without any problems via BLE.

Unfortunately, the following commands do not work via BLE:
wake and charge-port-open.

The following error messages are displayed:
wake: Failed to execute command: vcsec could not execute command: genericError:GENERICERROR_UNAUTHORIZED
charge-port-open: Failed to execute command: MESSAGEFAULT_ERROR_INSUFFICIENT_PRIVILEGES

Are these two problems fixable ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Add "Charging Manager" Role to BLE
2 participants